[webkit-reviews] review granted: [Bug 219661] Add runtime flag for ANGLE on Metal : [Attachment 415800] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 9 15:06:53 PST 2020


Sam Weinig <sam at webkit.org> has granted Dean Jackson <dino at apple.com>'s request
for review:
Bug 219661: Add runtime flag for ANGLE on Metal
https://bugs.webkit.org/show_bug.cgi?id=219661

Attachment 415800: Patch

https://bugs.webkit.org/attachment.cgi?id=415800&action=review




--- Comment #5 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 415800
  --> https://bugs.webkit.org/attachment.cgi?id=415800
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415800&action=review

> Source/WebCore/platform/graphics/GraphicsContextGLAttributes.h:56
> +#if PLATFORM(COCOA)

Might be slightly nicer to wrap these in HAVE(METAL) rather than
PLATFORM(COCOA), but I am not sure that exists yet.


More information about the webkit-reviews mailing list