[webkit-reviews] review granted: [Bug 219200] Support aspect-ratio on replaced elements : [Attachment 415794] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Rob Buis <rbuis at igalia.com>'s request
for review:
Bug 219200: Support aspect-ratio on replaced elements
https://bugs.webkit.org/show_bug.cgi?id=219200

Attachment 415794: Patch

https://bugs.webkit.org/attachment.cgi?id=415794&action=review




--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 415794
  --> https://bugs.webkit.org/attachment.cgi?id=415794
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415794&action=review

> Source/WebCore/rendering/svg/RenderSVGRoot.cpp:109
> +    if (style().aspectRatioType() == AspectRatioType::AutoAndRatio &&
!intrinsicRatioValue)
> +	   intrinsicRatio = style().logicalAspectRatio();
> +    else if (intrinsicRatioValue)
> +	   intrinsicRatio = *intrinsicRatioValue;

I would write it this way instead:

    if (intrinsicRatioValue)
	intrinsicRatio = *intrinsicRatioValue;
    else if (style().aspectRatioType() == AspectRatioType::AutoAndRatio)
	intrinsicRatio = style().logicalAspectRatio();