[webkit-reviews] review granted: [Bug 219024] WebDriver: add support for pen pointer events : [Attachment 414798] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 219024: WebDriver: add support for pen pointer events
https://bugs.webkit.org/show_bug.cgi?id=219024

Attachment 414798: Patch

https://bugs.webkit.org/attachment.cgi?id=414798&action=review




--- Comment #14 from Brian Burg <bburg at apple.com> ---
Comment on attachment 414798
  --> https://bugs.webkit.org/attachment.cgi?id=414798
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414798&action=review

r=me, overall the approach looks straightforward.

Unfortunately, watchOS build is still failing:

In file included from
/Volumes/Data/worker/watchOS-7-Build-EWS/build/WebKitBuild/Release-watchos/Deri
vedSources/WebKit2/unified-sources/UnifiedSource46-mm.mm:8:
/Volumes/Data/worker/watchOS-7-Build-EWS/build/Source/WebKit/UIProcess/ios/form
s/WKFocusedFormControlView.mm:134:27: error: reference to 'UIEvent' is
ambiguous
- (BOOL)handleWheelEvent:(UIEvent *)event
			  ^

This looks like another UnifiedSources thing, ugh. I'll try to figure out what
the right include is.

> Source/WebKit/Shared/WebMouseEvent.h:73
> +    const String& pointerType() const { return m_pointerType; }

It's a little weird to me that the pointerType is a string that we pass around.
Is there a reason to not use an enum?