[webkit-reviews] review granted: [Bug 219493] [GStreamer] Fix video losing size at the end of the stream : [Attachment 415305] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 3 11:00:51 PST 2020

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Alicia Boya García
<aboya at igalia.com>'s request for review:
Bug 219493: [GStreamer] Fix video losing size at the end of the stream

Attachment 415305: Patch


--- Comment #5 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 415305
  --> https://bugs.webkit.org/attachment.cgi?id=415305

View in context: https://bugs.webkit.org/attachment.cgi?id=415305&action=review

> +		       existingTrack->setPad(GRefPtr(pad));

Nit: Unless that for some reason you want to keep it explicit, you can remove
the GRefPtr constructor that will be called implicitly.

> +		       existingTrack->setPad(GRefPtr(pad));


> Source/WebCore/platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:179
> +void TrackPrivateBaseGStreamer::setPad(GRefPtr<GstPad>&& pad)
> +{
> +    m_pad = WTFMove(pad);
> +}

Nit: I think you can inline this in the header file.

More information about the webkit-reviews mailing list