[webkit-reviews] review granted: [Bug 219431] GPU Process WindowServer blocking prevents CGL : [Attachment 415299] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 3 10:59:00 PST 2020

Darin Adler <darin at apple.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 219431: GPU Process WindowServer blocking prevents CGL

Attachment 415299: Patch


--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 415299
  --> https://bugs.webkit.org/attachment.cgi?id=415299

View in context: https://bugs.webkit.org/attachment.cgi?id=415299&action=review

> Source/WebKit/GPUProcess/mac/GPUProcessMac.mm:48
> +    auto retval = CGSSetDenyWindowServerConnections(true);

Not really WebKit style to use the name "retval" and I would prefer "result",
"returnValue", or "errorCode", or even "error".

More information about the webkit-reviews mailing list