[webkit-reviews] review granted: [Bug 215905] AudioParam's minValue / maxValue are ignored : [Attachment 407436] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 215905: AudioParam's minValue / maxValue are ignored
https://bugs.webkit.org/show_bug.cgi?id=215905

Attachment 407436: Patch

https://bugs.webkit.org/attachment.cgi?id=407436&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 407436
  --> https://bugs.webkit.org/attachment.cgi?id=407436
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407436&action=review

> Source/WebCore/Modules/webaudio/AudioParamTimeline.h:55
> +    float valueForContextTime(BaseAudioContext&, float defaultValue, float
minValue, float maxValue, bool& hasValue);

Seems like we’d use optional for this instead of a "hasValue" out argument if
we were writing the code rather than importing code already written.

> Source/WebCore/Modules/webaudio/AudioParamTimeline.h:62
> +    float valuesForTimeRange(Seconds startTime, Seconds endTime, float
defaultValue, float minValue, float maxValue, float* values, unsigned
numberOfValues, double sampleRate, double controlRate);

Eventually such a large number of arguments starts calling for use of a
structure.