[webkit-reviews] review granted: [Bug 215816] [iOS] provide a way to get previously inserted alternatives for the selected text : [Attachment 407440] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 215816: [iOS] provide a way to get previously inserted alternatives for the
selected text
https://bugs.webkit.org/show_bug.cgi?id=215816

Attachment 407440: Patch

https://bugs.webkit.org/attachment.cgi?id=407440&action=review




--- Comment #9 from Darin Adler <darin at apple.com> ---
Comment on attachment 407440
  --> https://bugs.webkit.org/attachment.cgi?id=407440
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407440&action=review

> Source/WebKit/UIProcess/PageClient.h:381
> +    virtual NSTextAlternatives
*platformDictationAlternatives(WebCore::DictationContext) = 0;

I understand that I did not convince you to change this.

But "platform" is a very poor prefix to use to return a Cocoa-specific version
of a data structure. We have been using "platform" in multiple inconsistent
ways and it’s making our code hard to understand. The word "platform" itself is
ambiguous. And there’s no reason to be vague about what platform we mean unless
it’s a cross-platform abstraction. This never returns the dictation
alternatives of any other platform, so it’s platform-specific for Cocoa.

By naming it "platform" we leave the incorrect impression that other platforms
should some day implement this, and general spread a vague sense of uncertainty
about what this function does.