[webkit-reviews] review denied: [Bug 215871] Switch to class method for smart insert/delete : [Attachment 407363] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 26 18:40:47 PDT 2020


Darin Adler <darin at apple.com> has denied  review:
Bug 215871: Switch to class method for smart insert/delete
https://bugs.webkit.org/show_bug.cgi?id=215871

Attachment 407363: Patch

https://bugs.webkit.org/attachment.cgi?id=407363&action=review




--- Comment #13 from Darin Adler <darin at apple.com> ---
Comment on attachment 407363
  --> https://bugs.webkit.org/attachment.cgi?id=407363
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407363&action=review

>> Source/WebKit/UIProcess/ios/TextCheckerIOS.mm:120
>> +#if PLATFORM(HAVE_UIKEYBOARDIMPL_SMARTINSERTDELETE_CLASS_METHOD)
> 
> This is still not right. PLATFORM(HAVE_...)

Oh, right:

   #if HAVE(


More information about the webkit-reviews mailing list