[webkit-reviews] review granted: [Bug 215868] Add support for sub-sample accurate start for AudioBufferSourceNode : [Attachment 407354] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 26 18:29:44 PDT 2020
Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 215868: Add support for sub-sample accurate start for AudioBufferSourceNode
https://bugs.webkit.org/show_bug.cgi?id=215868
Attachment 407354: Patch
https://bugs.webkit.org/attachment.cgi?id=407354&action=review
--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 407354
--> https://bugs.webkit.org/attachment.cgi?id=407354
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=407354&action=review
Crash looks like it is related?
ASSERTION FAILED: m_finishedNodes.isEmpty()
./Modules/webaudio/BaseAudioContext.cpp(188) : virtual
WebCore::BaseAudioContext::~BaseAudioContext()
> Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp:82
> + size_t endFrame = 0;
Stray space after the "=" here.
> Source/WebCore/platform/audio/AudioUtilities.cpp:85
> + double frame = round(time * sampleRate * oversampleFactor) /
oversampleFactor;
> +
> + switch (rounding) {
> + case SampleFrameRounding::Nearest:
> + frame = round(frame);
> + break;
> + case SampleFrameRounding::Down:
> + frame = floor(frame);
> + break;
> + case SampleFrameRounding::Up:
> + frame = ceil(frame);
> + break;
> + }
std::round/floor/ceil? Should not matter here since it’s all double.
More information about the webkit-reviews
mailing list