[webkit-reviews] review granted: [Bug 215364] Web Inspector: breakpoint condition should be evaluated before the ignore count : [Attachment 407039] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 215364: Web Inspector: breakpoint condition should be evaluated before the
ignore count
https://bugs.webkit.org/show_bug.cgi?id=215364

Attachment 407039: Patch

https://bugs.webkit.org/attachment.cgi?id=407039&action=review




--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 407039
  --> https://bugs.webkit.org/attachment.cgi?id=407039
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407039&action=review

r=me

> Source/JavaScriptCore/debugger/Breakpoint.cpp:78
> +    return debugger.evaluateBreakpointCondition(*this, globalObject) &&
++m_hitCount > m_ignoreCount;

I find this one line unnecessarily complicated when all combined on one line.
I'd break it up kinda like it was before