[webkit-reviews] review granted: [Bug 215790] Crash in WebCore::AccessibilityRenderObject::textUnderElement in isolated tree mode. : [Attachment 407199] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 215790: Crash in WebCore::AccessibilityRenderObject::textUnderElement in
isolated tree mode.
https://bugs.webkit.org/show_bug.cgi?id=215790

Attachment 407199: Patch

https://bugs.webkit.org/attachment.cgi?id=407199&action=review




--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 407199
  --> https://bugs.webkit.org/attachment.cgi?id=407199
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407199&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:49
> +    None = 0,

Do we really need a None value? What is it used for?

> Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:82
> +#if PLATFORM(COCOA) && !PLATFORM(IOS_FAMILY)

I suggest #if PLATFORM(MAC) for greater clarity.

> Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:310
> +typedef std::pair<AXID, AXID> AccessibilityIsolatedTreeMathMultiscriptPair;

New code should use "using" instead of "typedef".