[webkit-reviews] review granted: [Bug 144457] Use jsTypeofIsObject() in DFG AI and operationTypeOfIsObject() : [Attachment 406897] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 144457: Use jsTypeofIsObject() in DFG AI and operationTypeOfIsObject()
https://bugs.webkit.org/show_bug.cgi?id=144457

Attachment 406897: Patch

https://bugs.webkit.org/attachment.cgi?id=406897&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 406897
  --> https://bugs.webkit.org/attachment.cgi?id=406897
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406897&action=review

r=me

> Source/JavaScriptCore/runtime/Operations.h:38
> +ALWAYS_INLINE bool jsTypeofIsObject(JSGlobalObject* globalObject, JSValue
value)

nit: Maybe break this into two functions: JSObject* and JSValue as argument
implementations, and have the DFG call the JSObject* parameter version.