[webkit-reviews] review granted: [Bug 215666] [JSC] Add Object.getOwnPropertyNames caching as it is done for Object.keys, and accelerate Object.getOwnPropertyDescriptor : [Attachment 406882] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 215666: [JSC] Add Object.getOwnPropertyNames caching as it is done for
Object.keys, and accelerate Object.getOwnPropertyDescriptor
https://bugs.webkit.org/show_bug.cgi?id=215666

Attachment 406882: Patch

https://bugs.webkit.org/attachment.cgi?id=406882&action=review




--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 406882
  --> https://bugs.webkit.org/attachment.cgi?id=406882
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406882&action=review

Nice. r=me

> Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:944
> +			       CachedPropertyNames key = node->op() ==
ObjectGetOwnPropertyNames ? CachedPropertyNames::OwnNames :
CachedPropertyNames::OwnKeys;

nit: Just put this inline in the function call below?

> Source/JavaScriptCore/runtime/StructureRareData.cpp:79
> +    auto validateAndAppend = [&](WriteBarrier<JSImmutableButterfly>& slot) {

nit: why not just have this in the loop below?

> Source/JavaScriptCore/runtime/StructureRareData.h:40
> +enum class CachedPropertyNames : uint8_t {

nit: I'd name this "CachedPropertyNamesKind" or similar