[webkit-reviews] review granted: [Bug 213884] [WK2] Add API to allow embedder to set a timezone override : [Attachment 404553] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 213884: [WK2] Add API to allow embedder to set a timezone override
https://bugs.webkit.org/show_bug.cgi?id=213884

Attachment 404553: Patch

https://bugs.webkit.org/attachment.cgi?id=404553&action=review




--- Comment #14 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 404553
  --> https://bugs.webkit.org/attachment.cgi?id=404553
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404553&action=review

> Source/WTF/wtf/DateMath.cpp:339
> +    if (tz.cal) {

I believe this uses uninitialized memory.  Add a { nullptr } to its
declaration.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/TimeZoneOverride.mm:7
> + * modify it under the terms of the GNU Library General Public
> + * License as published by the Free Software Foundation; either
> + * version 2 of the License, or (at your option) any later version.

Is there a reason this is not using the 2-clause BSD we usually use for new
files?	I think I'd prefer that unless there's a good reason to do this.