[webkit-reviews] review granted: [Bug 215453] REGRESSION (r260684): Messages YouTube inline video: after Multitasking away and Back, Audio is heard but icon indicates "muted" : [Attachment 406522] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 215453: REGRESSION (r260684): Messages YouTube inline video: after
Multitasking away and Back, Audio is heard but icon indicates "muted"
https://bugs.webkit.org/show_bug.cgi?id=215453

Attachment 406522: Patch

https://bugs.webkit.org/attachment.cgi?id=406522&action=review




--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 406522
  --> https://bugs.webkit.org/attachment.cgi?id=406522
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406522&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.h:1734
> +    void setIsDoingSnapshotSequence(bool);

"IsDoing" sounds a bit funny, and "snapshot sequence" sounds a bit vague (what
kind of snapshot? we do so many kinds).

isSnapshottingForApplicationSuspension, maybe?