[webkit-reviews] review granted: [Bug 211255] clearApplicationBundleIdentifierTestingOverride() should set the bundle identifier to null, not an empty string : [Attachment 398091] Patch

[bugzilla-daemon at webkit.org]

John Wilander <wilander at apple.com> has granted katherine_cheney at apple.com's
request for review:
Bug 211255: clearApplicationBundleIdentifierTestingOverride() should set the
bundle identifier to null, not an empty string
https://bugs.webkit.org/show_bug.cgi?id=211255

Attachment 398091: Patch

https://bugs.webkit.org/attachment.cgi?id=398091&action=review




--- Comment #4 from John Wilander <wilander at apple.com> ---
Comment on attachment 398091
  --> https://bugs.webkit.org/attachment.cgi?id=398091
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398091&action=review

r=me. Please address the comment.

> Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm:72
> +    applicationBundleIdentifierOverride() = String();

The bug title indicates that this should be nullptr. Either the title or this
assignment should be changed.