[webkit-reviews] review requested: [Bug 211250] Inline reportBlockedPortFailed and reportAuthenticationChallengeBlocked : [Attachment 398085] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 30 14:25:32 PDT 2020


Rob Buis <rbuis at igalia.com> has asked  for review:
Bug 211250: Inline reportBlockedPortFailed and
reportAuthenticationChallengeBlocked
https://bugs.webkit.org/show_bug.cgi?id=211250

Attachment 398085: Patch

https://bugs.webkit.org/attachment.cgi?id=398085&action=review




--- Comment #2 from Rob Buis <rbuis at igalia.com> ---
Comment on attachment 398085
  --> https://bugs.webkit.org/attachment.cgi?id=398085
Patch

Note that other solutions are possible as well, like making these private
methods in the caller classes, or finding a different place as free functions,
I just do not see the relation to FrameLoader.


More information about the webkit-reviews mailing list