[webkit-reviews] review requested: [Bug 211090] Make HistoryController an inner class of FrameLoader : [Attachment 397725] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 27 14:24:31 PDT 2020
Rob Buis <rbuis at igalia.com> has asked for review:
Bug 211090: Make HistoryController an inner class of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=211090
Attachment 397725: Patch
https://bugs.webkit.org/attachment.cgi?id=397725&action=review
--- Comment #2 from Rob Buis <rbuis at igalia.com> ---
Comment on attachment 397725
--> https://bugs.webkit.org/attachment.cgi?id=397725
Patch
PTAL. If this kind of design is acceptable I'd like to do the same for
PolicyChecker and DocumentLoader, as especially the latter adds a lot of public
API to FrameLoader that is only used by DocumentLoader, which could be made
private. These classes all look tightly coupled to me BTW.
More information about the webkit-reviews
mailing list