[webkit-reviews] review granted: [Bug 210835] [JSC] NumberConstructor should accept BigInt : [Attachment 397660] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 210835: [JSC] NumberConstructor should accept BigInt
https://bugs.webkit.org/show_bug.cgi?id=210835

Attachment 397660: Patch

https://bugs.webkit.org/attachment.cgi?id=397660&action=review




--- Comment #9 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 397660
  --> https://bugs.webkit.org/attachment.cgi?id=397660
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397660&action=review

r=me

> Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:3102
>  #if USE(BIGINT32)

Let's move this #if up around the "if (node->op() == CallNumberConstructor) {".

> Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:3109
>  #endif

Move below } below.