[webkit-reviews] review granted: [Bug 210996] Call addExtraFieldsToRequest with current load type : [Attachment 397508] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Rob Buis <rbuis at igalia.com>'s request
for review:
Bug 210996: Call addExtraFieldsToRequest with current load type
https://bugs.webkit.org/show_bug.cgi?id=210996

Attachment 397508: Patch

https://bugs.webkit.org/attachment.cgi?id=397508&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 397508
  --> https://bugs.webkit.org/attachment.cgi?id=397508
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397508&action=review

> Source/WebCore/ChangeLog:8
> +	   Call addExtraFieldsToRequest with current load type, not the
previous load type.

Is there any observable progression from this? If so, can we make a test
demonstrating it?

> Source/WebCore/loader/FrameLoader.cpp:1520
> +    ResourceRequest& request = newDocumentLoader.request();

I would have suggested auto& here.