[webkit-reviews] review granted: [Bug 210853] [Intl] Locale validation/canonicalization should defer to ICU : [Attachment 397505] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 210853: [Intl] Locale validation/canonicalization should defer to ICU
https://bugs.webkit.org/show_bug.cgi?id=210853

Attachment 397505: Patch

https://bugs.webkit.org/attachment.cgi?id=397505&action=review




--- Comment #10 from Darin Adler <darin at apple.com> ---
Comment on attachment 397505
  --> https://bugs.webkit.org/attachment.cgi?id=397505
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397505&action=review

> Source/JavaScriptCore/runtime/IntlObject.cpp:356
> +    return String(result.data(), resultLength);

Are these language tags ASCII? Latin-1? UTF-8?

This code is fine if they are ASCII or Latin-1, not if they are UTF-8.