[webkit-reviews] review granted: [Bug 210736] REGRESSION (r253987): StringImpl::adopt(Vector&&) copies only half of the characters in the Vector when copying across malloc zones : [Attachment 396983] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 210736: REGRESSION (r253987): StringImpl::adopt(Vector&&) copies only half
of the characters in the Vector when copying across malloc zones
https://bugs.webkit.org/show_bug.cgi?id=210736

Attachment 396983: Patch

https://bugs.webkit.org/attachment.cgi?id=396983&action=review




--- Comment #15 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 396983
  --> https://bugs.webkit.org/attachment.cgi?id=396983
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396983&action=review

r=me

>> Source/WTF/wtf/text/StringImpl.h:1044
>> +	    return create(vector.data(), vector.size());
> 
> Could have this do vector.clear() after creating the StringImpl, but I don’t
think that’s necessary.

Yeah, I think either is OK.