[webkit-reviews] review granted: [Bug 210751] Exit early in FrameLoader::loadURL when redirecting to another frame : [Attachment 396984] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Rob Buis <rbuis at igalia.com>'s
request for review:
Bug 210751: Exit early in FrameLoader::loadURL when redirecting to another
frame
https://bugs.webkit.org/show_bug.cgi?id=210751

Attachment 396984: Patch

https://bugs.webkit.org/attachment.cgi?id=396984&action=review




--- Comment #2 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 396984
  --> https://bugs.webkit.org/attachment.cgi?id=396984
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396984&action=review

r=me

> Source/WebCore/loader/FrameLoader.cpp:1358
> +    Frame* targetFrame = isFormSubmission ? nullptr :
findFrameForNavigation(effectiveFrameName);

This should be RefPtr.