[webkit-reviews] review granted: [Bug 210464] Web Inspector: Don't show tooltips for tabs : [Attachment 396462] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 210464: Web Inspector: Don't show tooltips for tabs
https://bugs.webkit.org/show_bug.cgi?id=210464

Attachment 396462: Patch

https://bugs.webkit.org/attachment.cgi?id=396462&action=review




--- Comment #4 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 396462
  --> https://bugs.webkit.org/attachment.cgi?id=396462
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396462&action=review

r=me

> Source/WebInspectorUI/ChangeLog:11
> +	   Don't show tooltips when they match the name of the tab. We no
longer truncate tab names
> +	   so the tooltip is redundant.
> +
> +	   Only show tooltips for settings and search (pinned tabs).

This is no longer an accurate description of this change.

> Source/WebInspectorUI/UserInterface/Views/TabBarItem.js:134
> +	       this._element.removeAttribute("title");

Why do we have to remove the attribute if it's an empty string?  Is it bad for
accessibility to have a `title=""` or even just a `title`?