[webkit-reviews] review requested: [Bug 209716] [ESNext] Implement logical assignment operators : [Attachment 396466] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has asked  for review:
Bug 209716: [ESNext] Implement logical assignment operators
https://bugs.webkit.org/show_bug.cgi?id=209716

Attachment 396466: Patch

https://bugs.webkit.org/attachment.cgi?id=396466&action=review




--- Comment #23 from Devin Rousso <drousso at apple.com> ---
Created attachment 396466

  --> https://bugs.webkit.org/attachment.cgi?id=396466&action=review

Patch

 - only `emitExpressionInfo` in `ShortCircuitReadModifyResolveNode` if the
non-local is not readonly (or we are not in strict mode)
 - use `emitNode` instead of `emitNodeInTailPosition` as technically the entire
assignment is in tail position, not just the rhs (it's equivalent to `a && (a =
b)`, NOT `a && (a = a && b)`)