[webkit-reviews] review granted: [Bug 210392] Make WTR::AccessibilityUIElements methods run on AX secondary thread. : [Attachment 396269] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 13 10:01:06 PDT 2020


chris fleizach <cfleizach at apple.com> has granted Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 210392: Make WTR::AccessibilityUIElements methods run on AX secondary
thread.
https://bugs.webkit.org/show_bug.cgi?id=210392

Attachment 396269: Patch

https://bugs.webkit.org/attachment.cgi?id=396269&action=review




--- Comment #5 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 396269
  --> https://bugs.webkit.org/attachment.cgi?id=396269
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396269&action=review

> Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:194
> +    for (NSUInteger i = 0; i < attributes.count; ++i) {

can we just do 
for (NSString *attribute in attributes) {


More information about the webkit-reviews mailing list