[webkit-reviews] review granted: [Bug 210363] Turn all instances of NavigatingToAppBoundDomain into Optionals. : [Attachment 396138] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted katherine_cheney at apple.com's
request for review:
Bug 210363: Turn all instances of NavigatingToAppBoundDomain into Optionals.
https://bugs.webkit.org/show_bug.cgi?id=210363

Attachment 396138: Patch

https://bugs.webkit.org/attachment.cgi?id=396138&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 396138
  --> https://bugs.webkit.org/attachment.cgi?id=396138
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396138&action=review

r=me

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1203
> +    auto shouldBeConsideredAppBound = !isNavigatingToAppBoundDomain ?
NavigatingToAppBoundDomain::Yes : *isNavigatingToAppBoundDomain;

Nit: I had to think about this for a minute before I understood it. I think
this *might* be clearer:

auto shouldBeConsideredAppBound = isNavigatingToAppBoundDomain ?
*isNavigatingToAppBoundDomain : NavigatingToAppBoundDomain::Yes;