[webkit-reviews] review granted: [Bug 210136] Switch unused IOKit classes from allow-with-report to deny-with-report : [Attachment 395717] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 10 10:51:25 PDT 2020


Per Arne Vollan <pvollan at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 210136: Switch unused IOKit classes from allow-with-report to
deny-with-report
https://bugs.webkit.org/show_bug.cgi?id=210136

Attachment 395717: Patch

https://bugs.webkit.org/attachment.cgi?id=395717&action=review




--- Comment #5 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 395717
  --> https://bugs.webkit.org/attachment.cgi?id=395717
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=395717&action=review

R=me.

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:603
> +#if __MAC_OS_X_VERSION_MIN_REQUIRED < 101500

Should this be '< 101600'?

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:612
> +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500

Should this be '>= 101600'?


More information about the webkit-reviews mailing list