[webkit-reviews] review granted: [Bug 210317] The rhs in `ReadModifyResolveNode` should be evaluated before throwing an exception if the lhs is read-only : [Attachment 396098] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 210317: The rhs in `ReadModifyResolveNode` should be evaluated before
throwing an exception if the lhs is read-only
https://bugs.webkit.org/show_bug.cgi?id=210317

Attachment 396098: Patch

https://bugs.webkit.org/attachment.cgi?id=396098&action=review




--- Comment #7 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 396098
  --> https://bugs.webkit.org/attachment.cgi?id=396098
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396098&action=review

r=me

> JSTests/stress/const-read-modify-assignment-eval-rhs-before-exception.js:27
> +Object.defineProperty(globalThis,
"testConstReadModifyAssignmentRHSEvalBeforeException", {

Hmm, if you don't remove this test you should probably at least change the
property name, since it's a `!var.local() && !var.isReadOnly()` red herring.