[webkit-reviews] review granted: [Bug 210109] [Tools] Fix gdb WebCoreQualifiedNamePrinter : [Attachment 395675] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 10 08:13:49 PDT 2020
Daniel Bates <dbates at webkit.org> has granted Alicia Boya García
<aboya at igalia.com>'s request for review:
Bug 210109: [Tools] Fix gdb WebCoreQualifiedNamePrinter
https://bugs.webkit.org/show_bug.cgi?id=210109
Attachment 395675: Patch
https://bugs.webkit.org/attachment.cgi?id=395675&action=review
--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 395675
--> https://bugs.webkit.org/attachment.cgi?id=395675
Patch
Patch looks good. A better patch would add test infra and a test for this
change though this can be done in a separate patch. Inspiration can be taken
from test-lldbWebKit.
More information about the webkit-reviews
mailing list