[webkit-reviews] review granted: [Bug 210331] [EME][GStreamer] remove m_cdmInstance ASSERT in cdmInstanceDetached : [Attachment 396081] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Charlie Turner
<cturner at igalia.com>'s request for review:
Bug 210331: [EME][GStreamer] remove m_cdmInstance ASSERT in cdmInstanceDetached
https://bugs.webkit.org/show_bug.cgi?id=210331

Attachment 396081: Patch

https://bugs.webkit.org/attachment.cgi?id=396081&action=review




--- Comment #3 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 396081
  --> https://bugs.webkit.org/attachment.cgi?id=396081
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396081&action=review

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:-378
8
> -    if (m_cdmInstance != &instance) {
> -	   GST_WARNING("passed CDMInstance %p is different from stored one %p",
&instance, m_cdmInstance.get());
> -	   ASSERT_NOT_REACHED();
> -	   return;
> -    }

I would still add this check inside the if, or even better, I would just bail
out if (!m_cdmInstance).