[webkit-reviews] review granted: [Bug 210312] Don't emit the rhs twice in `AssignResolveNode` : [Attachment 396027] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 210312: Don't emit the rhs twice in `AssignResolveNode`
https://bugs.webkit.org/show_bug.cgi?id=210312

Attachment 396027: Patch

https://bugs.webkit.org/attachment.cgi?id=396027&action=review




--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 396027
  --> https://bugs.webkit.org/attachment.cgi?id=396027
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396027&action=review

r=me

> Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:2913
> +    RefPtr<RegisterID> result = generator.emitNode(dst, m_right); // Execute
side effects first.

Nice.