[webkit-reviews] review granted: [Bug 202305] [GTK][WPE] Add about:gpu : [Attachment 379720] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 30 01:47:50 PDT 2019


Zan Dobersek <zan at falconsigh.net> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 202305: [GTK][WPE] Add about:gpu
https://bugs.webkit.org/show_bug.cgi?id=202305

Attachment 379720: Updated patch

https://bugs.webkit.org/attachment.cgi?id=379720&action=review




--- Comment #8 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 379720
  --> https://bugs.webkit.org/attachment.cgi?id=379720
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379720&action=review

> Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp:97
> +    return "WPE WEbKit";

Typo.

> Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp:134
> +#if USE(LIBEPOXY)
> +    if (epoxy_is_desktop_gl())
> +	   return "OpenGL";
> +    return "OpenGL ES 2";

In this case we could append "(libepoxy)" to the end of the GL string.


More information about the webkit-reviews mailing list