[webkit-reviews] review granted: [Bug 202358] [Nicosia] Complete ScrollingTreeNicosia::createScrollingTreeNode() : [Attachment 379823] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 30 01:04:51 PDT 2019


Carlos Garcia Campos <cgarcia at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 202358: [Nicosia] Complete ScrollingTreeNicosia::createScrollingTreeNode()
https://bugs.webkit.org/show_bug.cgi?id=202358

Attachment 379823: Patch

https://bugs.webkit.org/attachment.cgi?id=379823&action=review




--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 379823
  --> https://bugs.webkit.org/attachment.cgi?id=379823
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379823&action=review

> Source/WebCore/page/scrolling/nicosia/ScrollingTreeNicosia.cpp:74
> -    RELEASE_ASSERT_NOT_REACHED();
> +    ASSERT_NOT_REACHED();
> +    return ScrollingTreeFixedNode::create(*this, nodeID);

why?


More information about the webkit-reviews mailing list