[webkit-reviews] review denied: [Bug 202279] [iOS] Lock screen controls can fail to play web content : [Attachment 379663] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 202279: [iOS] Lock screen controls can fail to play web content
https://bugs.webkit.org/show_bug.cgi?id=202279

Attachment 379663: Patch

https://bugs.webkit.org/attachment.cgi?id=379663&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 379663
  --> https://bugs.webkit.org/attachment.cgi?id=379663
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379663&action=review

> Source/WebKit/Shared/Cocoa/ProcessTaskStateObserver.h:61
> +	   virtual void refClient() = 0;

Should these be private?

> Source/WebKit/Shared/Cocoa/ProcessTaskStateObserver.mm:72
> +    return *new ProcessTaskStateObserver(client);

Missing the adoptRef(), so this will leak.

> Source/WebKit/Shared/Cocoa/ProcessTaskStateObserver.mm:95
> +void ProcessTaskStateObserver::invalidate()

Who is calling this? I could not find a caller.

> Source/WebKit/Shared/Cocoa/ProcessTaskStateObserver.mm:104
> +    return makeRefPtr(m_client);

Note that this is not generally thread safe, what guarantees that the
destructor of m_client is not currently running on another thread.

> Source/WebKit/WebProcess/WebProcess.h:455
> +    void derefClient() final { ref(); }

should be deref() :(