[webkit-reviews] review granted: [Bug 202274] Stop using testRunner.overridePreference() to turn on Page Cache : [Attachment 379661] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 26 11:47:23 PDT 2019


Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 202274: Stop using testRunner.overridePreference() to turn on Page Cache
https://bugs.webkit.org/show_bug.cgi?id=202274

Attachment 379661: Patch

https://bugs.webkit.org/attachment.cgi?id=379661&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 379661
  --> https://bugs.webkit.org/attachment.cgi?id=379661
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379661&action=review

> Tools/DumpRenderTree/TestRunner.cpp:587
> +    RELEASE_ASSERT(!JSStringIsEqualToUTF8CString(key.get(),
"WebKitUsesPageCachePreferenceKey"));

These assertions seem a bit overboard.	If it does nothing in WebKitTestRunner,
future developers will realize that.


More information about the webkit-reviews mailing list