[webkit-reviews] review granted: [Bug 202066] eliding a move in Air O0 needs to mark the dest's old reg as available : [Attachment 379291] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 20 17:47:24 PDT 2019


Saam Barati <sbarati at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 202066: eliding a move in Air O0 needs to mark the dest's old reg as
available
https://bugs.webkit.org/show_bug.cgi?id=202066

Attachment 379291: Patch

https://bugs.webkit.org/attachment.cgi?id=379291&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 379291
  --> https://bugs.webkit.org/attachment.cgi?id=379291
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379291&action=review

>
Source/JavaScriptCore/b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp:12
8
> +    if (reg || (reg = m_map[tmp].reg)) {

can this assignment happen not in the if?


More information about the webkit-reviews mailing list