[webkit-reviews] review granted: [Bug 201986] JSTests/stress/ftl-put-by-id-setter-exception-interesting-live-state.js ftl-eager flavor fails intermittently. : [Attachment 379293] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Tadeu Zagallo
<tzagallo at apple.com>'s request for review:
Bug 201986:
JSTests/stress/ftl-put-by-id-setter-exception-interesting-live-state.js
ftl-eager flavor fails intermittently.
https://bugs.webkit.org/show_bug.cgi?id=201986

Attachment 379293: Patch

https://bugs.webkit.org/attachment.cgi?id=379293&action=review




--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 379293
  --> https://bugs.webkit.org/attachment.cgi?id=379293
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379293&action=review

r=me

> Source/JavaScriptCore/bytecode/AccessCase.cpp:238
> +bool AccessCase::doesCalls(Vector<JSCell*>* cellsToMarkIfDoesCalls) const

let's implement Yusuke's idea of listing all types() as a switch both in here
and in forEachDependentCell, so in the future, when someone adds a new type,
they'll get a compile error unless they implement the type in these functions.

> Source/JavaScriptCore/bytecode/PropertyCondition.cpp:354
>  bool PropertyCondition::isStillLive(VM& vm) const

If this is no longer called, let's remove it

> Source/JavaScriptCore/jit/PolymorphicCallStubRoutine.cpp:132
> +    bool isValid = true;

nit: let's call this isStillLive