[webkit-reviews] review denied: [Bug 201459] Use WebProcess processIdentifier to identify Service Worker connections : [Attachment 378180] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied youenn fablet <youennf at gmail.com>'s
request for review:
Bug 201459: Use WebProcess processIdentifier to identify Service Worker
connections
https://bugs.webkit.org/show_bug.cgi?id=201459

Attachment 378180: Patch

https://bugs.webkit.org/attachment.cgi?id=378180&action=review




--- Comment #8 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 378180
  --> https://bugs.webkit.org/attachment.cgi?id=378180
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378180&action=review

> Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h:324
> +    HashMap<uint64_t, WeakPtr<WebSWServerConnection>> m_swConnections;

Going from a strong identifier type to uint64_t seems like a pretty bad
regression for me :/