[webkit-reviews] review denied: [Bug 201422] REGRESSION(r249428): [GStreamer] VP9 video rendered green : [Attachment 378181] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 6 08:23:37 PDT 2019


Philippe Normand <pnormand at igalia.com> has denied Chris Lord
<clord at igalia.com>'s request for review:
Bug 201422: REGRESSION(r249428): [GStreamer] VP9 video rendered green
https://bugs.webkit.org/show_bug.cgi?id=201422

Attachment 378181: Patch

https://bugs.webkit.org/attachment.cgi?id=378181&action=review




--- Comment #2 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 378181
  --> https://bugs.webkit.org/attachment.cgi?id=378181
Patch

I confirm this approach works but I would prefer, if possible, to make glupload
behave the same for all video formats. For vp9 the "Raw Data" uploader is
selected, I suspect this is related with the issue at hand. For h264 the
GLMemory uploader is selected and that works well. So I would like to
understand why the glupload behavior differs.


More information about the webkit-reviews mailing list