[webkit-reviews] review granted: [Bug 203492] [GTK][WPE] Fix non-unified builds after r251436 : [Attachment 382082] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Adrian Perez
<aperez at igalia.com>'s request for review:
Bug 203492: [GTK][WPE] Fix non-unified builds after r251436
https://bugs.webkit.org/show_bug.cgi?id=203492

Attachment 382082: Patch

https://bugs.webkit.org/attachment.cgi?id=382082&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 382082
  --> https://bugs.webkit.org/attachment.cgi?id=382082
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382082&action=review

> Source/JavaScriptCore/ChangeLog:3
> +	   [GTK][WPE] Fix non-unified builds after r251436

This isn't caused by r251436

> Source/JavaScriptCore/runtime/ObjectInitializationScope.h:32
> +#ifdef NDEBUG
> +#include "VM.h"

Let's try to avoid protecting #includes with #ifdef NDEBUG, because that would
lead to strange debug-only or release-only build failures.