[webkit-reviews] review granted: [Bug 189142] Properties that take <position> should not accept 3 values : [Attachment 381988] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 189142: Properties that take <position> should not accept 3 values
https://bugs.webkit.org/show_bug.cgi?id=189142

Attachment 381988: Patch

https://bugs.webkit.org/attachment.cgi?id=381988&action=review




--- Comment #6 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 381988
  --> https://bugs.webkit.org/attachment.cgi?id=381988
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381988&action=review

> Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:926
> +	   if (values[i + 1] && !values[i + 1]->isValueID())

Relying on caller to ensure i + 1 is not out of bounds is not very nice. How
about passing values as std::array or something?