[webkit-reviews] review granted: [Bug 203434] Web Inspector: Right-clicking in color picker should not select color : [Attachment 381967] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 25 14:36:10 PDT 2019
Devin Rousso <drousso at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 203434: Web Inspector: Right-clicking in color picker should not select
color
https://bugs.webkit.org/show_bug.cgi?id=203434
Attachment 381967: Patch
https://bugs.webkit.org/attachment.cgi?id=381967&action=review
--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 381967
--> https://bugs.webkit.org/attachment.cgi?id=381967
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=381967&action=review
rs=me
> Source/WebInspectorUI/UserInterface/Views/ColorSquare.js:152
> + if (event.button !== 0 || event.ctrlKey)
Does this work for non-macOS systems too? Should it only check for
`event.ctrlKey` if `WI.Platform.name === "mac"`?
More information about the webkit-reviews
mailing list