[webkit-reviews] review granted: [Bug 200764] Main implementation for lazy image loading : [Attachment 381946] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 25 14:47:56 PDT 2019


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Rob Buis
<rbuis at igalia.com>'s request for review:
Bug 200764: Main implementation for lazy image loading
https://bugs.webkit.org/show_bug.cgi?id=200764

Attachment 381946: Patch

https://bugs.webkit.org/attachment.cgi?id=381946&action=review




--- Comment #75 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 381946
  --> https://bugs.webkit.org/attachment.cgi?id=381946
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381946&action=review

> Source/WebCore/loader/cache/CachedResourceLoader.h:65
> +enum class ImageRequestOption : uint8_t { Now, Defer };

I think this could use a better name. Maybe ImageLoading { Immediate, Deferred
} ? Or DeferredUntilVisible?

> LayoutTests/ChangeLog:8
> +	   Import relevant tests into http/tests/lazyload.

Do they have to be http tests? Should they be web platform tests?


More information about the webkit-reviews mailing list