[webkit-reviews] review granted: [Bug 203270] Refactor "builds" table "build_number" row to "build_tag" to fit more generic use cases. : [Attachment 381633] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted dewei_zhu at apple.com's request for
review:
Bug 203270: Refactor "builds" table "build_number" row to "build_tag" to fit
more generic use cases.
https://bugs.webkit.org/show_bug.cgi?id=203270

Attachment 381633: Patch

https://bugs.webkit.org/attachment.cgi?id=381633&action=review




--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 381633
  --> https://bugs.webkit.org/attachment.cgi?id=381633
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381633&action=review

> Websites/perf.webkit.org/public/api/upload-root.php:14
> +	   exit_with_error('ShouldNotHaveBothBuildNumberAndBuildTag',
array('buildNumber' => $_POST['buildNumber'], 'buildTag' =>
$_POST['buildTag']));

This is a lengthly error message. Also, it seems fine if we specified both &
both are identical during the transition period.
Why not check the values? and return BuilderNumberTagMismatch in the case
they're not equal.

> Websites/perf.webkit.org/public/include/report-processor.php:110
> +	   if (array_key_exists('buildNumber', $report)) {
> +	       if (array_key_exists('buildTag', $report))

Ditto about allowing both if they're identical.