[webkit-reviews] review granted: [Bug 200932] [WebAuthn] Warn users when multiple NFC tags present : [Attachment 381533] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 200932: [WebAuthn] Warn users when multiple NFC tags present
https://bugs.webkit.org/show_bug.cgi?id=200932

Attachment 381533: Patch

https://bugs.webkit.org/attachment.cgi?id=381533&action=review




--- Comment #6 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 381533
  --> https://bugs.webkit.org/attachment.cgi?id=381533
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381533&action=review

Looks good! Nice to see more WPT's passing. r=me.

> Source/WebKit/UIProcess/WebAuthentication/AuthenticatorTransportService.h:60
> +    // These operation are guaranteed to execute asynchronously.

These operations are ...

> Source/WebKit/UIProcess/WebAuthentication/Cocoa/NfcConnection.mm:133
> +    NSError *error = nil;

You don't have to initialize to 'nil' in ObjC. It happens automatically.

> Source/WebKit/UIProcess/WebAuthentication/Mock/MockNfcService.mm:259
> +	       [tags addObject:adoptNS([[WKMockNFTag alloc]
initWithType:NFTagTypeGeneric4A tagID:adoptNS([[NSData alloc]
initWithBytes:tagID2 length:sizeof(tagID2)]).get()]).get()];

Could something in here be 'mutable' so we can leave this as a 'const' method?
(Assuming the mutation is not something that actually changes the logical
constness of the object?)