[webkit-reviews] review granted: [Bug 202101] Support for callbacks for manifest events : [Attachment 381314] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 202101: Support for callbacks for manifest events
https://bugs.webkit.org/show_bug.cgi?id=202101

Attachment 381314: Patch

https://bugs.webkit.org/attachment.cgi?id=381314&action=review




--- Comment #3 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 381314
  --> https://bugs.webkit.org/attachment.cgi?id=381314
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381314&action=review

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.mm:3519
> +    UNUSED_PARAM(output);
> +    UNUSED_PARAM(track);
> +
> +    ensureOnMainThread([self, strongSelf = retainPtr(self), metadataGroups =
retainPtr(groups)]() mutable {
> +	   m_taskQueue.enqueueTask([player = m_player, metadataGroups =
WTFMove(metadataGroups), currentTime = m_player->currentMediaTime()] {
> +	       if (!player)
> +		   return;
> +
> +	       for (AVDateRangeMetadataGroup *group in metadataGroups.get())
> +		   player->metadataDidArrive(retainPtr(group.items),
currentTime);
> +	   });
> +    });

Nit: why are we using a background queue if we're just going to dispatch to the
main thread?