[webkit-reviews] review granted: [Bug 203155] Web Inspector: Elements: $0 is shown for the wrong node when selecting elements in a user agent shadow tree : [Attachment 381311] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 203155: Web Inspector: Elements: $0 is shown for the wrong node when
selecting elements in a user agent shadow tree
https://bugs.webkit.org/show_bug.cgi?id=203155

Attachment 381311: Patch

https://bugs.webkit.org/attachment.cgi?id=381311&action=review




--- Comment #2 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 381311
  --> https://bugs.webkit.org/attachment.cgi?id=381311
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381311&action=review

r=me

> Source/WebInspectorUI/ChangeLog:8
> +	   Rather than "blindly" using the last selected node (from
`WI.TreeOutline`), we should wait

Switch to a more descriptive term like 'naively', so you can eliminate the
double-quotes.

> Source/WebInspectorUI/ChangeLog:9
> +	   to see if the inspected page actually "accepts" the selected node as
being inspectable and

Let's not use quotation marks around words like this. AMA style says that other
than quoting material directly from a source, quotation marks are used "to
introduce a word or phrase used as an ironic comment, as slang, or as an
invented or coined expression". Pick words that are more technical/descriptive
if necessary, or just remove the quotes.