[webkit-reviews] review granted: [Bug 166484] Add the support for ShadowRoot.delegateFocus : [Attachment 380813] Adds the support

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 166484: Add the support for ShadowRoot.delegateFocus
https://bugs.webkit.org/show_bug.cgi?id=166484

Attachment 380813: Adds the support

https://bugs.webkit.org/attachment.cgi?id=380813&action=review




--- Comment #5 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 380813
  --> https://bugs.webkit.org/attachment.cgi?id=380813
Adds the support

View in context: https://bugs.webkit.org/attachment.cgi?id=380813&action=review

> Source/WebCore/dom/ShadowRoot.cpp:59
> +ShadowRoot::ShadowRoot(Document& document, ShadowRootMode type, bool
delegatesFocus)

Please use enum in the interface. The member can be bool.

> Source/WebCore/dom/ShadowRoot.h:45
> +    enum class FocusDelegation { Yes, No };

You even have one, you are just not using it!