[webkit-reviews] review granted: [Bug 202865] Clearing Website data for a given session should not shut down cached processes for other sessions : [Attachment 380795] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 202865: Clearing Website data for a given session should not shut down
cached processes for other sessions
https://bugs.webkit.org/show_bug.cgi?id=202865

Attachment 380795: Patch

https://bugs.webkit.org/attachment.cgi?id=380795&action=review




--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 380795
  --> https://bugs.webkit.org/attachment.cgi?id=380795
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380795&action=review

> Source/WebKit/UIProcess/WebProcessProxy.h:274
> +    class ScopePreventingShutdown {

It would be nice to have some sort of WTF template for this. The pattern shows
up occasionally.

> Source/WebKit/UIProcess/WebProcessProxy.h:284
> +	   ~ScopePreventingShutdown()
> +	   {
> +	       if (m_process) {

m_process can't be null here.

> Source/WebKit/UIProcess/WebProcessProxy.h:292
> +	   RefPtr<WebProcessProxy> m_process;

Ref<>?